diff --git a/docs/plans/sidebar-filtros-salvos-proximidade-impl.md b/docs/plans/sidebar-filtros-salvos-proximidade-impl.md index 7c8cbc6e..b6ef0175 100644 --- a/docs/plans/sidebar-filtros-salvos-proximidade-impl.md +++ b/docs/plans/sidebar-filtros-salvos-proximidade-impl.md @@ -24,6 +24,7 @@ flowchart TD ``` **Opções consideradas:** + - **A:** Só esconder chevron mas manter estado open — rejeitada (viola aceite). - **B:** Mover sub-lista para fora do `SidebarMenuItem` de Municípios — rejeitada (quebra semântica de filho; mais churn). - **C (recomendada):** Remover disclosure no componente existente; apagar API de open; apertar `mt`/`py` no `SidebarMenuSub` localmente. diff --git a/src/components/campaign/shell/MunicipalityNavSavedFilters.tsx b/src/components/campaign/shell/MunicipalityNavSavedFilters.tsx index 129f2746..ea2e8dc6 100644 --- a/src/components/campaign/shell/MunicipalityNavSavedFilters.tsx +++ b/src/components/campaign/shell/MunicipalityNavSavedFilters.tsx @@ -50,9 +50,9 @@ export const MunicipalityNavSavedFilters = ({ onNavigate }: { onNavigate: () => const menuItem = row?.closest('[data-sidebar="menu-item"]') const successor = savedFilters.length > 1 - ? (row?.nextElementSibling ?? row?.previousElementSibling)?.querySelector( + ? ((row?.nextElementSibling ?? row?.previousElementSibling)?.querySelector( '[data-sidebar="menu-sub-button"]', - ) ?? menuItem?.querySelector('a') + ) ?? menuItem?.querySelector('a')) : menuItem?.querySelector('a') removeMunicipalitySavedFilter(entry.href) @@ -91,9 +91,7 @@ export const MunicipalityNavSavedFilters = ({ onNavigate }: { onNavigate: () => - handleRemove(entry, event.currentTarget.closest('li')) - } + onClick={(event) => handleRemove(entry, event.currentTarget.closest('li'))} aria-label={`Apagar o filtro salvo ${entry.name}`} className="top-1 group-focus-within/menu-sub-item:opacity-100 group-hover/menu-sub-item:opacity-100 md:opacity-0" > diff --git a/tests/e2e/campaignSavedFilters.e2e.spec.ts b/tests/e2e/campaignSavedFilters.e2e.spec.ts index ae8a64dc..bc085206 100644 --- a/tests/e2e/campaignSavedFilters.e2e.spec.ts +++ b/tests/e2e/campaignSavedFilters.e2e.spec.ts @@ -111,11 +111,7 @@ test.describe('Filtros salvos de Municípios', () => { await page.reload() await expect(shortcut).toBeVisible(NAVIGATION) - await expect( - page.getByRole('list', { name: 'Filtros salvos de Municípios' }), - ).toBeVisible() - await expect( - page.getByRole('button', { name: /filtros salvos de Municípios/i }), - ).toHaveCount(0) + await expect(page.getByRole('list', { name: 'Filtros salvos de Municípios' })).toBeVisible() + await expect(page.getByRole('button', { name: /filtros salvos de Municípios/i })).toHaveCount(0) }) })