Cross-checked by parallel code-quality/performance/reuse reviewers against
the E9 commit. Behavior-preserving:
- laterTimestamp/resolveMunicipalityLastSignalAt were the same "latest of
two ISO timestamps" written twice; both now delegate to a new
latestIsoTimestamp in campaignTime.ts, which documents the fixed-width
UTC invariant that makes the string compare sound.
- Hoisted the frescor comparator's Date.now() out of the per-comparison
accessor so the sort key stops drifting mid-sort.
- Deleted the unread baseTotal/growthFactor/belowBase passthrough from the
statewide goal entry point and fixed a comment citing a symbol
(goalDecompositionBelowBase) that never existed; renamed
computeStatewideGoalDecomposition -> computeStatewideSuggestedGoals now
that nothing is proportionally decomposed.
- Collapsed the advisor badge's two copies (desktop table vs mobile card)
into one AdvisorStatusBadge; they had quietly diverged on which icon
renders for the "no advisor" state.
- Renamed the sort-menu's stale "Cobertura" label for advisor coverage to
"Assessoria" (E8 already renamed the list column for the same reason);
derived the sort-key set from the label record instead of a third
parallel list.
- Consolidated three zeroed-scenario-record literals into one
zeroByVoteEstimateScenario() factory in voteEstimate.ts.
- Routed three separate votesByYear[2022] reads through one votesInYear
helper in municipalityPotential.ts.
- Gated the goal card's empty-state copy on !usesMesaEstimate so it stops
telling a município with an existing mesa estimate to enter one.
- Swapped a test assertion pinned to a raw Tailwind token for a stable
data-signal="cold" hook, and tightened the "desert" test's bound to
check against the actual growth factor (the old bound was true for
every slug regardless of the formula).
Left alone (roadmap decision, not cleanup): sanityCheckSuggestedGoalsByTerritory
has no production caller yet (deferred to E11/E12); comment shortened
instead of deleting the dead-but-documented code.
Verified: tsc --noEmit, pnpm lint (0 warnings), 337 unit + 366 integration
tests, pnpm build all green.
E2E-driven fixes (the suite now passes 9/9; two journeys remain
latency-flaky on cold dev compiles and pass on retry):
- leader home crashed with Forbidden since the remodel:
loadLeaderContactsPageData loaded municipality options through the
staff-scoped loader (leaders are denied municipality reads); their scope
now derives from the engaged leadership's linked municipalities
- leaders saw 'Contato — —' instead of their supporters' names:
getAccessibleContactIds now mirrors canReadSupporter for leaders
(contacts of supporters they created)
- leader nav had two items with the same /campanha href (duplicate React
keys); the leader home IS the contact tool — one entry
- RSC serialization contracts: CampaignListPagination is a server component
again (hrefForPage stays server-side; CampaignTransitionAnchor client leaf
intercepts clicks with serializable props); CampaignSearchForm takes
basePath instead of a function prop
- hasAnyEstimate moved from the 'use client' PledgeEstimateForm to
voteEstimate.ts — server components may not call client-module exports
- playwright.config honors TEQO_TEST_DATABASE_URL (parity with
vitest.setup.ts) and uses a fixed .next/e2e dist dir so Next stops
appending per-PID entries to tsconfig include; report artifacts
eslint-ignored
Rename the operational unit "Praça"/"Núcleo" to "Município" (code identifier
`municipality`) and land the 2026-07-23 course changes:
- New `candidate` role with unrestricted visibility (`isCampaignStaff` now
includes it) alongside coordinator/advisor; leader is locked down to the
supporter contact tool only.
- Demandas become staff-only; dobradinhas modeled via a `stateDeputy` entity.
- Camaçari consolidated to a single município (ZE 170/171 aggregated);
Salvador keeps its 19 zone municípios.
- Map moves to the staff dashboard; `/campanha/municipios` is list/overview.
- Vote pledges keep the declared vs estimated (scenario) asymmetry; leaders
never see estimates.
Destructive migration for the campaign vertical (drops nucleus/plaza-era
tables, wipes campaign rows, seeds 435 municípios). Public-site data untouched.
Includes the post-delivery /simplify cleanups: shared reloadStaffActor /
reloadCoordinatorActor helpers, req.context cache for getFreshCampaignUser,
parallelized dashboard loads, candidate dashboard-copy fix, and dead
leader-dashboard / roleKind code removal.
