mirror of
https://github.com/fsolla/teqo.git
synced 2026-11-13 15:13:07 +00:00
31fcc20ffd
Cross-checked by parallel code-quality/performance/reuse reviewers against the E9 commit. Behavior-preserving: - laterTimestamp/resolveMunicipalityLastSignalAt were the same "latest of two ISO timestamps" written twice; both now delegate to a new latestIsoTimestamp in campaignTime.ts, which documents the fixed-width UTC invariant that makes the string compare sound. - Hoisted the frescor comparator's Date.now() out of the per-comparison accessor so the sort key stops drifting mid-sort. - Deleted the unread baseTotal/growthFactor/belowBase passthrough from the statewide goal entry point and fixed a comment citing a symbol (goalDecompositionBelowBase) that never existed; renamed computeStatewideGoalDecomposition -> computeStatewideSuggestedGoals now that nothing is proportionally decomposed. - Collapsed the advisor badge's two copies (desktop table vs mobile card) into one AdvisorStatusBadge; they had quietly diverged on which icon renders for the "no advisor" state. - Renamed the sort-menu's stale "Cobertura" label for advisor coverage to "Assessoria" (E8 already renamed the list column for the same reason); derived the sort-key set from the label record instead of a third parallel list. - Consolidated three zeroed-scenario-record literals into one zeroByVoteEstimateScenario() factory in voteEstimate.ts. - Routed three separate votesByYear[2022] reads through one votesInYear helper in municipalityPotential.ts. - Gated the goal card's empty-state copy on !usesMesaEstimate so it stops telling a município with an existing mesa estimate to enter one. - Swapped a test assertion pinned to a raw Tailwind token for a stable data-signal="cold" hook, and tightened the "desert" test's bound to check against the actual growth factor (the old bound was true for every slug regardless of the formula). Left alone (roadmap decision, not cleanup): sanityCheckSuggestedGoalsByTerritory has no production caller yet (deferred to E11/E12); comment shortened instead of deleting the dead-but-documented code. Verified: tsc --noEmit, pnpm lint (0 warnings), 337 unit + 366 integration tests, pnpm build all green.
391 lines
14 KiB
TypeScript
391 lines
14 KiB
TypeScript
import { readFileSync } from 'node:fs'
|
|
import { resolve } from 'node:path'
|
|
import { createElement } from 'react'
|
|
import { renderToStaticMarkup } from 'react-dom/server'
|
|
import { describe, expect, it, vi } from 'vitest'
|
|
|
|
import { AppRouterContext } from 'next/dist/shared/lib/app-router-context.shared-runtime'
|
|
|
|
import { CampaignScopeBadge } from '@/components/campaign/CampaignScopeBadge'
|
|
import { MunicipalityList } from '@/components/campaign/MunicipalityList'
|
|
import { SupportStatusBadge } from '@/components/campaign/SupportStatusBadge'
|
|
import { TseZoneBadge } from '@/components/campaign/TseZoneBadge'
|
|
import { Progress } from '@/components/ui/Progress'
|
|
import { Toggle } from '@/components/ui/Toggle'
|
|
import { ToggleGroup, ToggleGroupItem } from '@/components/ui/ToggleGroup'
|
|
import type { CampaignFormActionState } from '@/utilities/campaignFormActionError'
|
|
import { createEmptyGoalCoverageByScenario } from '@/utilities/goalCoverage'
|
|
import type { MunicipalityAdvisorSummary, MunicipalityListViewModel } from '@/utilities/municipalityViewModels'
|
|
import { toVoteEstimateScenarioViewModel } from '@/utilities/voteEstimate'
|
|
import { createEmptyMunicipalityPledgeAggregate } from '@/utilities/votePledgeData'
|
|
|
|
import { stub } from '../helpers/stub'
|
|
|
|
vi.mock('next/navigation', () => ({
|
|
useRouter: () => ({
|
|
replace: vi.fn(),
|
|
push: vi.fn(),
|
|
}),
|
|
}))
|
|
|
|
const noopListFormAction = async (
|
|
_state: CampaignFormActionState,
|
|
_formData: FormData,
|
|
): Promise<CampaignFormActionState> => ({})
|
|
|
|
const municipalityListDefaultProps = {
|
|
isCoordinator: false,
|
|
advisorOptions: [],
|
|
trendFormAction: noopListFormAction,
|
|
advisorsFormAction: noopListFormAction,
|
|
state: { page: 1 },
|
|
}
|
|
|
|
const mockAppRouter = stub<Parameters<typeof AppRouterContext.Provider>[0]['value']>({
|
|
push: () => {},
|
|
replace: () => {},
|
|
refresh: () => {},
|
|
forward: () => {},
|
|
back: () => {},
|
|
prefetch: () => Promise.resolve(),
|
|
})
|
|
|
|
const renderWithAppRouter = (element: React.ReactElement) =>
|
|
renderToStaticMarkup(createElement(AppRouterContext.Provider, { value: mockAppRouter }, element))
|
|
|
|
describe('campaign visual foundation', () => {
|
|
it('exposes the current progress value to assistive technology', () => {
|
|
const html = renderToStaticMarkup(createElement(Progress, { value: 42 }))
|
|
|
|
expect(html).toContain('role="progressbar"')
|
|
expect(html).toContain('aria-valuenow="42"')
|
|
})
|
|
|
|
it.each(['sm', 'default', 'lg'] as const)(
|
|
'keeps the %s toggle at least 44 by 44 pixels',
|
|
(size) => {
|
|
const html = renderToStaticMarkup(createElement(Toggle, { size }, 'Filtro'))
|
|
|
|
expect(html).toContain('min-h-11')
|
|
expect(html).toContain('min-w-11')
|
|
},
|
|
)
|
|
|
|
it('keeps toggle group items at least 44 by 44 pixels', () => {
|
|
const html = renderToStaticMarkup(
|
|
createElement(
|
|
ToggleGroup,
|
|
{ type: 'single' },
|
|
createElement(ToggleGroupItem, { value: 'engajado' }, 'Engajado'),
|
|
),
|
|
)
|
|
|
|
expect(html).toContain('data-slot="toggle-group-item"')
|
|
expect(html).toContain('min-h-11')
|
|
expect(html).toContain('min-w-11')
|
|
})
|
|
|
|
it('renders campaign scope with a visible, accessible label', () => {
|
|
const html = renderToStaticMarkup(
|
|
createElement(CampaignScopeBadge, null, '3 municípios sob sua assessoria'),
|
|
)
|
|
|
|
expect(html).toContain('3 municípios sob sua assessoria')
|
|
expect(html).toContain('data-scope="campaign"')
|
|
})
|
|
|
|
it('keeps the authenticated shell fixed while its content pane scrolls', () => {
|
|
const layoutSource = readFileSync(
|
|
resolve(process.cwd(), 'src/app/(campaign)/campanha/(app)/layout.tsx'),
|
|
'utf8',
|
|
)
|
|
const sidebarSource = readFileSync(
|
|
resolve(process.cwd(), 'src/components/campaign/CampaignSidebar.tsx'),
|
|
'utf8',
|
|
)
|
|
|
|
expect(layoutSource).toContain(
|
|
'className="h-svh min-h-0 overflow-hidden print:h-auto print:overflow-visible"',
|
|
)
|
|
expect(layoutSource).toContain('data-slot="campaign-content-scroll"')
|
|
expect(layoutSource).toContain('min-h-0 flex-1 overflow-y-auto overscroll-contain')
|
|
expect(sidebarSource).toContain('h-svh shrink-0')
|
|
})
|
|
|
|
it('uses light sidebar tokens and readable logout states', () => {
|
|
const styles = readFileSync(resolve(process.cwd(), 'src/app/(frontend)/styles.css'), 'utf8')
|
|
const sidebarSource = readFileSync(
|
|
resolve(process.cwd(), 'src/components/campaign/CampaignSidebar.tsx'),
|
|
'utf8',
|
|
)
|
|
|
|
expect(styles).toContain('--sidebar: #fafaf9')
|
|
expect(styles).toContain('--sidebar-foreground: #1c1917')
|
|
expect(styles).toContain('--sidebar-accent-foreground: #1c1917')
|
|
expect(sidebarSource).toContain('text-sidebar-foreground')
|
|
expect(sidebarSource).toContain('hover:text-sidebar-accent-foreground')
|
|
})
|
|
|
|
it.each([
|
|
['engajado', 'Engajado'],
|
|
['a_abordar', 'A abordar'],
|
|
['em_disputa', 'Em disputa'],
|
|
['negativo', 'Negativo'],
|
|
] as const)('renders the %s support status with text and semantic state', (status, label) => {
|
|
const html = renderToStaticMarkup(createElement(SupportStatusBadge, { status }))
|
|
|
|
expect(html).toContain(label)
|
|
expect(html).toContain(`data-support-status="${status}"`)
|
|
})
|
|
|
|
it('qualifies TSE zones instead of showing an ambiguous number', () => {
|
|
const html = renderToStaticMarkup(createElement(TseZoneBadge, { zoneNumber: 12 }))
|
|
|
|
expect(html).toContain('ZE 12')
|
|
expect(html).toContain('aria-label="Zona Eleitoral TSE 12"')
|
|
})
|
|
|
|
it('renders municipality rows with geography, pledges, and advisor coverage for staff', () => {
|
|
const advisor: MunicipalityAdvisorSummary = { id: 7, name: 'Ana Bastos', phone: null }
|
|
const municipalities: MunicipalityListViewModel[] = [
|
|
{
|
|
id: 1,
|
|
name: 'Seabra',
|
|
slug: 'seabra',
|
|
kind: 'municipio',
|
|
city: 'Seabra',
|
|
region: 'Chapada Diamantina',
|
|
ibgeCode: '2929800',
|
|
zoneNumber: null,
|
|
advisorIDs: [advisor.id],
|
|
priority: 'alta',
|
|
lastUpdateAt: null,
|
|
lastSignalAt: null,
|
|
expectedVotes: { pessimistic: null, central: 1500, optimistic: null },
|
|
politicalTrendStatus: 'favoravel',
|
|
politicalTrendNote: null,
|
|
pledges: {
|
|
declaredTotal: 1200,
|
|
effectiveByScenario: { pessimistic: 1200, central: 1200, optimistic: 1200 },
|
|
pledgeCount: 2,
|
|
missingEstimateCount: 1,
|
|
lastPledgeAt: null,
|
|
},
|
|
votePosition2022: {
|
|
votes: 4200,
|
|
rank: 12,
|
|
share: 0.031,
|
|
totalUnits: 435,
|
|
},
|
|
goalCoverageByScenario: {
|
|
pessimistic: { goal: 1500, committed: 1200, coverageRatio: 0.8, deficit: 300 },
|
|
central: { goal: 1500, committed: 1200, coverageRatio: 0.8, deficit: 300 },
|
|
optimistic: { goal: 1500, committed: 1200, coverageRatio: 0.8, deficit: 300 },
|
|
},
|
|
},
|
|
{
|
|
id: 2,
|
|
name: 'Salvador — ZE 3',
|
|
slug: 'salvador-ze-3',
|
|
kind: 'zona',
|
|
city: 'Salvador',
|
|
region: 'Metropolitano de Salvador',
|
|
ibgeCode: '2927408',
|
|
zoneNumber: 3,
|
|
advisorIDs: [],
|
|
priority: 'normal',
|
|
lastUpdateAt: null,
|
|
lastSignalAt: null,
|
|
expectedVotes: toVoteEstimateScenarioViewModel(null),
|
|
politicalTrendStatus: null,
|
|
politicalTrendNote: null,
|
|
pledges: createEmptyMunicipalityPledgeAggregate(),
|
|
votePosition2022: null,
|
|
goalCoverageByScenario: createEmptyGoalCoverageByScenario(),
|
|
},
|
|
]
|
|
|
|
const html = renderWithAppRouter(
|
|
createElement(MunicipalityList, {
|
|
municipalities,
|
|
advisorNamesById: new Map([[advisor.id, advisor]]),
|
|
isStaffView: true,
|
|
...municipalityListDefaultProps,
|
|
}),
|
|
)
|
|
|
|
expect(html).toContain('Seabra')
|
|
expect(html).toContain('Chapada Diamantina')
|
|
expect(html).toContain('href="/campanha/municipios/seabra"')
|
|
expect(html).toContain('1.500')
|
|
expect(html).toContain('Cenários de estimativa')
|
|
expect(html).toContain('Prioritária')
|
|
expect(html).toContain('Coberta')
|
|
expect(html).toContain('Sem assessor')
|
|
expect(html).toContain('Tendência')
|
|
expect(html).toContain('Cobertura da meta')
|
|
expect(html).toContain('80%')
|
|
expect(html).toContain('Faltam 300 votos para a meta')
|
|
})
|
|
|
|
/**
|
|
* E9 allocation queue: the two row-level signals the queue is scanned for —
|
|
* a priority município nobody answers for, and a signal that went cold.
|
|
*/
|
|
it('names a priority município with no advisor and ages its last signal', () => {
|
|
const staleDays = 40
|
|
const staleSignal = new Date(Date.now() - staleDays * 86_400_000).toISOString()
|
|
|
|
const html = renderWithAppRouter(
|
|
createElement(MunicipalityList, {
|
|
municipalities: [
|
|
{
|
|
id: 9,
|
|
name: 'Barreiras',
|
|
slug: 'barreiras',
|
|
kind: 'municipio',
|
|
city: 'Barreiras',
|
|
region: 'Bacia do Rio Grande',
|
|
ibgeCode: '2903201',
|
|
zoneNumber: null,
|
|
advisorIDs: [],
|
|
priority: 'alta',
|
|
lastUpdateAt: staleSignal,
|
|
lastSignalAt: staleSignal,
|
|
expectedVotes: toVoteEstimateScenarioViewModel(null),
|
|
politicalTrendStatus: null,
|
|
politicalTrendNote: null,
|
|
pledges: createEmptyMunicipalityPledgeAggregate(),
|
|
votePosition2022: null,
|
|
goalCoverageByScenario: createEmptyGoalCoverageByScenario(),
|
|
},
|
|
],
|
|
advisorNamesById: new Map<number, MunicipalityAdvisorSummary>(),
|
|
isStaffView: true,
|
|
...municipalityListDefaultProps,
|
|
}),
|
|
)
|
|
|
|
// "Sem assessor" still appears in the Assessores column (the avatar stack's
|
|
// empty state); the status badge is what escalates to "Sem responsável".
|
|
expect(html).toContain('Sem responsável')
|
|
expect(html).toContain(`há ${staleDays} dias`)
|
|
expect(html).toContain('data-signal="cold"')
|
|
expect(html).toContain('Último sinal')
|
|
})
|
|
|
|
it('reads "Sem sinal" when nothing was ever recorded for the município', () => {
|
|
const html = renderWithAppRouter(
|
|
createElement(MunicipalityList, {
|
|
municipalities: [
|
|
{
|
|
id: 10,
|
|
name: 'Uauá',
|
|
slug: 'uaua',
|
|
kind: 'municipio',
|
|
city: 'Uauá',
|
|
region: 'Semiárido Nordeste II',
|
|
ibgeCode: '2932002',
|
|
zoneNumber: null,
|
|
advisorIDs: [],
|
|
priority: 'normal',
|
|
lastUpdateAt: null,
|
|
lastSignalAt: null,
|
|
expectedVotes: toVoteEstimateScenarioViewModel(null),
|
|
politicalTrendStatus: null,
|
|
politicalTrendNote: null,
|
|
pledges: createEmptyMunicipalityPledgeAggregate(),
|
|
votePosition2022: null,
|
|
goalCoverageByScenario: createEmptyGoalCoverageByScenario(),
|
|
},
|
|
],
|
|
advisorNamesById: new Map<number, MunicipalityAdvisorSummary>(),
|
|
isStaffView: true,
|
|
...municipalityListDefaultProps,
|
|
}),
|
|
)
|
|
|
|
expect(html).toContain('Sem sinal')
|
|
expect(html).toContain('Sem assessor')
|
|
expect(html).not.toContain('Sem responsável')
|
|
})
|
|
|
|
it('hides leadership coverage subline when pledges only have declared votes', () => {
|
|
const html = renderWithAppRouter(
|
|
createElement(MunicipalityList, {
|
|
municipalities: [
|
|
{
|
|
id: 3,
|
|
name: 'Itaberaba',
|
|
slug: 'itaberaba',
|
|
kind: 'municipio',
|
|
city: 'Itaberaba',
|
|
region: 'Centro Norte',
|
|
ibgeCode: '2914703',
|
|
zoneNumber: null,
|
|
advisorIDs: [],
|
|
priority: 'normal',
|
|
lastUpdateAt: null,
|
|
lastSignalAt: null,
|
|
expectedVotes: toVoteEstimateScenarioViewModel(null),
|
|
politicalTrendStatus: null,
|
|
politicalTrendNote: null,
|
|
pledges: {
|
|
declaredTotal: 800,
|
|
effectiveByScenario: { pessimistic: 800, central: 800, optimistic: 800 },
|
|
pledgeCount: 1,
|
|
missingEstimateCount: 1,
|
|
lastPledgeAt: null,
|
|
},
|
|
votePosition2022: null,
|
|
goalCoverageByScenario: createEmptyGoalCoverageByScenario(),
|
|
},
|
|
],
|
|
advisorNamesById: new Map<number, MunicipalityAdvisorSummary>(),
|
|
isStaffView: true,
|
|
...municipalityListDefaultProps,
|
|
}),
|
|
)
|
|
|
|
expect(html).toContain('Itaberaba')
|
|
expect(html).not.toContain('>Nas lideranças')
|
|
expect(html).not.toContain('Declarado nas lideranças')
|
|
})
|
|
|
|
it('hides staff-only pledge and coverage columns from the leader view', () => {
|
|
const html = renderWithAppRouter(
|
|
createElement(MunicipalityList, {
|
|
municipalities: [
|
|
{
|
|
id: 1,
|
|
name: 'Seabra',
|
|
slug: 'seabra',
|
|
kind: 'municipio',
|
|
city: 'Seabra',
|
|
region: 'Chapada Diamantina',
|
|
ibgeCode: '2929800',
|
|
zoneNumber: null,
|
|
advisorIDs: [],
|
|
priority: 'alta',
|
|
lastUpdateAt: null,
|
|
lastSignalAt: null,
|
|
expectedVotes: toVoteEstimateScenarioViewModel(null),
|
|
politicalTrendStatus: null,
|
|
politicalTrendNote: null,
|
|
pledges: createEmptyMunicipalityPledgeAggregate(),
|
|
votePosition2022: null,
|
|
goalCoverageByScenario: createEmptyGoalCoverageByScenario(),
|
|
},
|
|
],
|
|
advisorNamesById: new Map<number, MunicipalityAdvisorSummary>(),
|
|
isStaffView: false,
|
|
...municipalityListDefaultProps,
|
|
}),
|
|
)
|
|
|
|
expect(html).toContain('Seabra')
|
|
expect(html).not.toContain('Votos estimados')
|
|
expect(html).not.toContain('Cobertura')
|
|
expect(html).not.toContain('Prioritária')
|
|
})
|
|
})
|