mirror of
https://github.com/fsolla/teqo.git
synced 2026-11-13 15:05:19 +00:00
O rename mecanico deixou um defeito silencioso e alguns fosseis: o fixture de
recentVisits perdeu o ${index} (todas as entradas com o mesmo label, invisivel
porque o label nao era asserido) e access/shared.ts guardava "action plan" em
prosa, forma que o guard de vocabulario nao cobria. O padrao agora tolera espaco
e a allowlist encolheu: o comentario de campaignMigrationReconciliation cita
activity e o arquivo saiu da excecao.
Na migration, a entrada action_plan_municipality_idx era inalcancavel (nenhuma
migration jamais criou esse nome) e saiu, deixando up() e down() com os mesmos
48 pares; as duas buscas de FK passam a usar to_regclass, que retorna NULL em vez
de lancar -- a unica consulta que contradizia a invariante do proprio cabecalho.
O detalhe de organizacao para de derivar o rotulo de status a mao e reusa
ActivityStatusBadge, com status tipado como ActivityStatus no loader.
Debitos do /simplify registrados: C8 F4b (o guard de formActions so inspeciona
arquivos chamados exatamente formActions.ts) no plano do C8; defers e descartes
com gatilho no plano do C13.
153 lines
6.5 KiB
TypeScript
153 lines
6.5 KiB
TypeScript
import { existsSync, readdirSync, readFileSync } from 'node:fs'
|
|
import { relative, resolve } from 'node:path'
|
|
import { describe, expect, it } from 'vitest'
|
|
|
|
import {
|
|
legacyCamelCaseFilenameIgnores,
|
|
legacyComponentFilenameIgnores,
|
|
legacyComponentSyntaxIgnores,
|
|
legacyFrameworkExportIgnores,
|
|
} from '../../eslint-legacy-ignores.mjs'
|
|
|
|
// Programmatic guards for conventions that used to be enforced only by prose
|
|
// (codebase-map.mdc / docs/ARCHITECTURE.md) and drifted during Pass 2.
|
|
|
|
const repoRoot = process.cwd()
|
|
|
|
const walkSourceFiles = (root: string, extensions: readonly string[]): string[] =>
|
|
readdirSync(root, { recursive: true, withFileTypes: true })
|
|
.filter((entry) => entry.isFile() && extensions.some((ext) => entry.name.endsWith(ext)))
|
|
.map((entry) => resolve(entry.parentPath, entry.name))
|
|
|
|
const repoPath = (absolute: string) => relative(repoRoot, absolute)
|
|
|
|
describe('server-only boundary in src/utilities', () => {
|
|
// Files that value-import Payload run server code; if they ever land in a
|
|
// client bundle the failure must be a build error, not a runtime surprise.
|
|
// W2 marked 21 loaders by hand — this pins the rule for every new module.
|
|
// Deliberate exceptions go here, each with a justification:
|
|
const allowlist = new Set<string>([])
|
|
|
|
const isTypeOnlyClause = (clause: string): boolean => {
|
|
if (/^type\b/.test(clause.trim())) return true
|
|
const inner = clause.trim().match(/^\{([\s\S]*)\}$/)?.[1]
|
|
if (inner === undefined) return false
|
|
return inner
|
|
.split(',')
|
|
.map((specifier) => specifier.trim())
|
|
.filter(Boolean)
|
|
.every((specifier) => specifier.startsWith('type '))
|
|
}
|
|
|
|
it('marks every Payload-coupled utilities module with import server-only', () => {
|
|
const offenders: string[] = []
|
|
|
|
for (const file of walkSourceFiles(resolve(repoRoot, 'src/utilities'), ['.ts', '.tsx'])) {
|
|
const source = readFileSync(file, 'utf8')
|
|
// Side-effect imports (`import 'x'`) never match: the clause group
|
|
// cannot contain quotes, so it cannot swallow a bare specifier.
|
|
const importsPayloadValues = [
|
|
...source.matchAll(/^import\s+([^'"]+?)\s+from\s+['"](payload|@payload-config)['"]/gm),
|
|
].some(([, clause]) => !isTypeOnlyClause(clause!))
|
|
|
|
if (!importsPayloadValues) continue
|
|
if (/^import 'server-only'/m.test(source)) continue
|
|
if (allowlist.has(repoPath(file))) continue
|
|
offenders.push(repoPath(file))
|
|
}
|
|
|
|
expect(offenders, "add `import 'server-only'` (or a justified allowlist entry)").toEqual([])
|
|
})
|
|
})
|
|
|
|
describe('banned campaign terminology', () => {
|
|
// Every rename of an operational concept leaves prose behind: the 2026-07-23
|
|
// remodel ("Praça"/"Núcleo" → "Município") needed a manual W4f sweep that
|
|
// still missed 4 consent drafts, and C13 ("Plano de Ação" → "Atividade")
|
|
// touched 62 files. Each retired term gets a row here so it cannot come back.
|
|
// Migrations are frozen history and stay out of scope; allowlisted files
|
|
// carry legitimate data or frozen SQL, not live copy.
|
|
const bannedTerms = [
|
|
{
|
|
id: 'Praça/Núcleo',
|
|
pattern: /praç|núcleo/i,
|
|
remedy: 'use "Município" (or allowlist genuine data)',
|
|
allowlist: [
|
|
'src/lib/cities.ts', // real locality names (e.g. "Núcleo Bandeirante" — DF)
|
|
// Emits the frozen remodel migration, which names the term it retired.
|
|
'scripts/generate-remodel-municipalities-migration.mjs',
|
|
],
|
|
},
|
|
{
|
|
id: 'Plano de Ação',
|
|
// Accent-tolerant (agents routinely type "plano de acao") and space-tolerant,
|
|
// so English prose ("action plan") cannot slip past the identifier forms.
|
|
pattern: /action[\s_-]?plan|planos? de a[çc][aã]o|\/campanha\/planos/i,
|
|
remedy: 'use "Atividade" / activity (or allowlist frozen history)',
|
|
allowlist: [
|
|
// Emits the frozen remodel migration, whose SQL predates the rename.
|
|
'scripts/generate-remodel-municipalities-migration.mjs',
|
|
],
|
|
},
|
|
] as const
|
|
|
|
const searchRoots = ['src', 'tests', 'scripts'] as const
|
|
|
|
it.each(bannedTerms)('keeps $id out of src, tests and scripts', (term) => {
|
|
// This spec quotes the banned literals itself.
|
|
const allowlist = new Set<string>([...term.allowlist, repoPath(import.meta.filename)])
|
|
const offenders: string[] = []
|
|
|
|
for (const root of searchRoots) {
|
|
for (const file of walkSourceFiles(resolve(repoRoot, root), ['.ts', '.tsx', '.mjs'])) {
|
|
const path = repoPath(file)
|
|
if (path.startsWith('src/migrations/')) continue
|
|
if (allowlist.has(path)) continue
|
|
|
|
const lines = readFileSync(file, 'utf8').split('\n')
|
|
for (const [index, line] of lines.entries()) {
|
|
if (term.pattern.test(line)) offenders.push(`${path}:${index + 1}`)
|
|
}
|
|
}
|
|
}
|
|
|
|
expect(offenders, term.remedy).toEqual([])
|
|
})
|
|
})
|
|
|
|
describe('eslint legacy ignore lists', () => {
|
|
// ESLint never validates ignore paths, so a file move silently orphans its
|
|
// exemption (campaign-logo.tsx broke this way during Pass 2 W2).
|
|
const unescapeGlob = (pattern: string) => pattern.replaceAll('\\[', '[').replaceAll('\\]', ']')
|
|
|
|
it.each([
|
|
['legacyComponentFilenameIgnores', legacyComponentFilenameIgnores],
|
|
['legacyFrameworkExportIgnores', legacyFrameworkExportIgnores],
|
|
['legacyComponentSyntaxIgnores', legacyComponentSyntaxIgnores],
|
|
['legacyCamelCaseFilenameIgnores', legacyCamelCaseFilenameIgnores],
|
|
])('every %s entry still exists on disk', (_name, entries) => {
|
|
const missing = entries.filter((entry) => !existsSync(resolve(repoRoot, unescapeGlob(entry))))
|
|
expect(missing, 'file moved or deleted — update eslint-legacy-ignores.mjs').toEqual([])
|
|
})
|
|
})
|
|
|
|
describe('campaign formActions convention', () => {
|
|
// Every route-level formActions.ts goes through the shared wrappers
|
|
// (runCampaignFormAction / runCampaignRedirectFormAction) so error mapping
|
|
// and revalidation cannot drift per route (Pass 2 W4d). A file that truly
|
|
// cannot use them gets an allowlist entry documenting why:
|
|
const allowlist = new Set<string>([])
|
|
|
|
it('routes every formActions.ts through a shared wrapper', () => {
|
|
const offenders = walkSourceFiles(resolve(repoRoot, 'src/app/(campaign)'), ['.ts'])
|
|
.filter((file) => file.endsWith('/formActions.ts'))
|
|
.map(repoPath)
|
|
.filter((path) => !allowlist.has(path))
|
|
.filter(
|
|
(path) =>
|
|
!/runCampaign(Redirect)?FormAction/.test(readFileSync(resolve(repoRoot, path), 'utf8')),
|
|
)
|
|
|
|
expect(offenders, 'wrap with runCampaignFormAction/runCampaignRedirectFormAction').toEqual([])
|
|
})
|
|
})
|