mirror of
https://github.com/fsolla/teqo.git
synced 2026-11-13 15:13:07 +00:00
adb1773be8
The migration put this control on a phone for the first time and it was still mouse-sized: a 28px submit and checkbox rows with no minimum height, where the siblings size both for touch. Closing the overlay mid-submit was worse — it unmounts the Alert and the live region while nothing aborts the request, so a failure went unreported; it now uses the same `reportFailure` the trend and estimate cells do. The rest is what the reviewers found around it: the trigger reports `aria-busy` like every other overlay caller, `canSubmit` carries the override rule that was stranded in the JSX, the two-level-jump check reads `ENGAGEMENT_LEVEL_RULES.maxStepsWithoutShock` instead of a literal so E15 cannot desync the checkbox from the rule behind it, and the route echoes `updated.engagementLevel` rather than the requested one — with `overrideAccess: false` Payload drops a field the actor cannot write instead of refusing, so the request is not evidence the movement landed. The cell's state stopped being nullable, which meant splitting it from the route's success payload: a success always names a level, a row need not have one. And the control joins `overlayCases`, the table that exists to catch exactly the kind of container mistake this migration could have made. |
||
|---|---|---|
| .. | ||
| e2e | ||
| fixtures | ||
| helpers | ||
| int | ||
| unit | ||