teqo-backup/tests/int/campaignMunicipalityAdvisorMembership.int.spec.ts
Francisco Ignácio Fontoura Solla 7c50e29aa7 B27: combobox + chips + auto-save no popover de Assessores da lista de municípios
Replaces the checkbox-list + "Salvar assessores" button in the
Assessors popover (/campanha/municipios) with removable chips + a
Command combobox, delta-based auto-save (one advisor add/remove per
request, never the whole array), and optimistic UI with request
sequencing to resolve out-of-order responses correctly.

- New POST /campanha/municipios/advisors JSON route (mirrors
  expected-votes/), backed by setMunicipalityAdvisorMembership(Record)
  in actions/municipality.ts (text advisory lock + transaction).
- nextAdvisorIdsAfterMembership moved to
  src/lib/municipalityAdvisorMembership.ts with unit tests.
- Shared isSameOriginRequest (src/utilities/sameOriginRequest.ts) and
  uniqueRelationshipIds (src/utilities/relationship.ts) helpers,
  de-duplicating the same-origin CSRF check and the
  Set+map(relationshipId)+filter pattern across advisor call sites.
- MunicipalityListAdvisorsControl.tsx rewritten: chips, Command
  combobox, per-item pending affordance, rollback on error, and a
  request-sequence guard so only the most recently sent delta's
  response is adopted when concurrent optimistic updates settle.
- e2e coverage for the combobox auto-save flow; setup prewarms the new
  POST-only route to avoid Playwright dev-server HMR aborting the
  first request.
- Plan and roadmap marked as delivered (B27).
2026-07-26 03:31:51 -03:00

151 lines
5.3 KiB
TypeScript

// @vitest-environment node
import type { Payload } from 'payload'
import { getPayload } from 'payload'
import { beforeAll, describe, expect, it } from 'vitest'
import { setMunicipalityAdvisorMembershipRecord } from '@/app/(campaign)/campanha/actions/municipality'
import config from '@/payload.config'
import { installCampaignFixtures } from '../helpers/campaignFixtures'
let payload: Payload
const campaignFixtures = installCampaignFixtures({
getPayload: () => payload,
setPayload: (nextPayload) => {
payload = nextPayload
},
})
describe('setMunicipalityAdvisorMembershipRecord (B27)', () => {
beforeAll(async () => {
payload = await getPayload({ config: await config })
})
it.each(['coordinator', 'candidate'] as const)(
'lets a %s assign and remove an advisor by delta',
async (role) => {
const fixtures = campaignFixtures()
const actor = await fixtures.createCampaignUser(role)
const advisor = await fixtures.createCampaignUser('advisor')
const municipality = await fixtures.getMunicipality()
const assigned = await setMunicipalityAdvisorMembershipRecord(payload, actor, {
municipality: municipality.id,
advisor: advisor.id,
assigned: true,
})
fixtures.touchMunicipality(municipality.id)
expect(
assigned.advisors?.map((entry) => (typeof entry === 'number' ? entry : entry.id)),
).toContain(advisor.id)
const removed = await setMunicipalityAdvisorMembershipRecord(payload, actor, {
municipality: municipality.id,
advisor: advisor.id,
assigned: false,
})
expect(
removed.advisors?.map((entry) => (typeof entry === 'number' ? entry : entry.id)) ?? [],
).not.toContain(advisor.id)
},
)
it('lets a coordinator assign themself or the candidate — the path assertTargetAdvisor would block', async () => {
const fixtures = campaignFixtures()
const coordinator = await fixtures.createCampaignUser('coordinator')
const candidate = await fixtures.createCampaignUser('candidate')
const municipality = await fixtures.getMunicipality()
const selfAssigned = await setMunicipalityAdvisorMembershipRecord(payload, coordinator, {
municipality: municipality.id,
advisor: coordinator.id,
assigned: true,
})
fixtures.touchMunicipality(municipality.id)
expect(
selfAssigned.advisors?.map((entry) => (typeof entry === 'number' ? entry : entry.id)),
).toContain(coordinator.id)
const candidateAssigned = await setMunicipalityAdvisorMembershipRecord(payload, coordinator, {
municipality: municipality.id,
advisor: candidate.id,
assigned: true,
})
expect(
candidateAssigned.advisors?.map((entry) => (typeof entry === 'number' ? entry : entry.id)),
).toContain(candidate.id)
})
it('denies advisor and leader actors', async () => {
const fixtures = campaignFixtures()
const advisorActor = await fixtures.createCampaignUser('advisor')
const leaderActor = await fixtures.createCampaignUser('leader')
const target = await fixtures.createCampaignUser('advisor')
const municipality = await fixtures.getMunicipality()
await expect(
setMunicipalityAdvisorMembershipRecord(payload, advisorActor, {
municipality: municipality.id,
advisor: target.id,
assigned: true,
}),
).rejects.toThrow(/coordenação geral ou o candidato/i)
await expect(
setMunicipalityAdvisorMembershipRecord(payload, leaderActor, {
municipality: municipality.id,
advisor: target.id,
assigned: true,
}),
).rejects.toThrow(/coordenação geral ou o candidato/i)
})
it('is idempotent (no-op returns the same document without re-writing)', async () => {
const fixtures = campaignFixtures()
const coordinator = await fixtures.createCampaignUser('coordinator')
const advisor = await fixtures.createCampaignUser('advisor')
const municipality = await fixtures.getMunicipality()
await setMunicipalityAdvisorMembershipRecord(payload, coordinator, {
municipality: municipality.id,
advisor: advisor.id,
assigned: true,
})
fixtures.touchMunicipality(municipality.id)
const again = await setMunicipalityAdvisorMembershipRecord(payload, coordinator, {
municipality: municipality.id,
advisor: advisor.id,
assigned: true,
})
expect(again.advisors?.map((entry) => (typeof entry === 'number' ? entry : entry.id))).toEqual([
advisor.id,
])
})
it('rejects once the municipality is at the 10-advisor cap', async () => {
const fixtures = campaignFixtures()
const coordinator = await fixtures.createCampaignUser('coordinator')
const municipality = await fixtures.getMunicipality()
for (let index = 0; index < 10; index += 1) {
const advisor = await fixtures.createCampaignUser('advisor')
await setMunicipalityAdvisorMembershipRecord(payload, coordinator, {
municipality: municipality.id,
advisor: advisor.id,
assigned: true,
})
}
fixtures.touchMunicipality(municipality.id)
const eleventh = await fixtures.createCampaignUser('advisor')
await expect(
setMunicipalityAdvisorMembershipRecord(payload, coordinator, {
municipality: municipality.id,
advisor: eleventh.id,
assigned: true,
}),
).rejects.toThrow(/no máximo 10 assessores/i)
})
})