0a63621d4b
nextStateDeputyIdsAfterMunicipalityMembership was the third byte-for-byte copy of the same single-id delta — nextAdvisorIdsAfterMembership and nextStateDeputyIdsAfterMembership differ from it only in which cap they read — so the algorithm now lives once in nextIdsAfterMembership with the cap as data, and the three named wrappers just bind their own. The three cloned spec files became one describe.each suite: coverage went up rather than down, since every relation now gets the "can go to zero" and no-mutation cases only B37's clone had, plus an explicit assertion that each wrapper refuses at ITS cap with ITS message. That pairing matters because mapCampaignFormActionError matches thrown messages against safeMessages by exact string, and two of those cap messages were bare literals in three src places each (thrown, plus two independent allowlists): rewording any one would have silently collapsed a real refusal into "tente novamente". Both are constants now, next to their caps, following the MUNICIPALITY_STATE_DEPUTIES_CAP_MESSAGE precedent already in those same files. The dobradinha staff message had the same exposure in four places — and actions/stateDeputy.ts already imported the constant while restating it as a literal one line below — so it is STATE_DEPUTY_STAFF_MESSAGE (renamed: it guards create/update too, not just the batch), and the conflict message it shares with the create route is named too. The batch action stopped resolving the dobradinha slug before its loop: the slug exists only to target the revalidate, which the caller already skips when nothing changed, so on a no-op batch that read was fetched and thrown away — the guard setLeadershipMunicipalitiesMembershipRecord already had. Its redundant second dedup is gone (the schema's transform already deduped; the sort stays, for deadlock-free lock ordering), and the bare 435 shared with the advisor batch is MAX_MUNICIPALITIES_PER_BATCH. Two memoization gaps closed, both restoring invariants the codebase had already established elsewhere. An advisor's scoped .filter() returned a fresh array per row, defeating the WeakMap that exists precisely to share derivations across rows, so scopedPortfolioIndex memoizes on (index, addableIds) and every row gets one array. And LeadershipStateDeputyRelationCell called matchesAtWordStart per candidate, paying an NFD pass plus three Unicode regexes on both sides per keystroke over the unpaginated leadership catalog — the cost wordStartFilter's own doc comment warns about; it now normalizes the query once against labels cached on options, like municipalityPortfolio. Rejected with reason: maxItems on the dobradinhas cell. A dobradinha has no product ceiling on municípios (that is why the bound is the catalog), so a "generous 30" would invent a rule that refuses a legitimate statewide dobradinha, and the honest 435 is unreachable when ids are unique. Also dropped the dead addPlaceholder knob no caller ever set.
32 lines
1.4 KiB
TypeScript
32 lines
1.4 KiB
TypeScript
/**
|
|
* Returns the next id list after applying ONE membership change to a bounded
|
|
* relation, or `null` when the owner is already in the desired state (no write
|
|
* needed) — the shape every chip-toggled relation in `/campanha` needs before
|
|
* it writes: `municipality.advisors` (B19/B27), `leadership.stateDeputies`
|
|
* (B31/B36) and `municipality.stateDeputies` (B37).
|
|
*
|
|
* The cap travels as data because that is the only thing that differs between
|
|
* them, and its `message` is a constant owned by the relation's schema rather
|
|
* than a literal: `mapCampaignFormActionError` matches thrown messages against
|
|
* `safeMessages` by exact string, so a reworded throw would silently collapse
|
|
* a real refusal into the generic "tente novamente".
|
|
*
|
|
* Not the batch sibling: `nextMunicipalityIdsAfterLeadershipMembership` moves a
|
|
* whole território at once and enforces a floor, so it reports `added`/`changed`
|
|
* instead of just the next list.
|
|
*/
|
|
export const nextIdsAfterMembership = (
|
|
currentIDs: readonly number[],
|
|
id: number,
|
|
assigned: boolean,
|
|
cap: { max: number; message: string },
|
|
): number[] | null => {
|
|
const alreadyAssigned = currentIDs.includes(id)
|
|
if (assigned === alreadyAssigned) return null
|
|
|
|
if (assigned) {
|
|
if (currentIDs.length >= cap.max) throw new Error(cap.message)
|
|
return [...currentIDs, id]
|
|
}
|
|
return currentIDs.filter((currentId) => currentId !== id)
|
|
}
|