createCalendarFeedLinkRecord failed with `overrideAccess:false` + `user: campaignUser` because Payload stripped the required `secretSlug`/`createdBy` fields (create access was admin-only) -> 400 behind the generic message; revokeCalendarFeedRecord silently no-opped (revokedAt update access also admin-only). - canCreateCalendarFeed now enforces advisor filterMunicipality scope on data (canCreateSupporter precedent) + canSetCalendarFeedSecret / canSetCalendarFeedRevocation permit staff to mint the secret on create and mark a feed revoked; secret read stays `() => false` and update admin-only. - CalendarFeed stamps createdBy via stampCampaignCreatedBy; secret create + revokedAt update use the new staff field accesses. - Action refactored to `*Record` (payload, actor) cores + thin wrappers; assertFilterMunicipalityInScope (tour precedent); console.error keeps the real error on the server while the friendly message stays. - 10 int tests for create/scope/revoke/leader/secret; fixture tracks calendarFeed cleanup. Closes #436
81 lines
2.9 KiB
TypeScript
81 lines
2.9 KiB
TypeScript
import type { Access, FieldAccess } from 'payload'
|
|
|
|
import { relationshipId } from '@/lib/relationship'
|
|
import { getAccessibleMunicipalityIds } from '@/utilities/access/municipalities'
|
|
import {
|
|
getFreshCampaignUser,
|
|
isCampaignStaff,
|
|
isCampaignUnrestricted,
|
|
isPayloadAdmin,
|
|
} from '@/utilities/access/shared'
|
|
|
|
export const canCreateCalendarFeed: Access = async ({ data, req }) => {
|
|
if (isPayloadAdmin(req.user)) return true
|
|
|
|
const currentUser = await getFreshCampaignUser(req)
|
|
if (isCampaignUnrestricted(currentUser)) return true
|
|
if (!currentUser || !isCampaignStaff(currentUser)) return false
|
|
|
|
// The remaining staff role is advisor. A pinned filter municipality must be one
|
|
// the advisor administers (same shape as `canCreateSupporter`); the same scope
|
|
// is re-derived on every read, so an unfiltered feed stays within scope too.
|
|
const municipalityID = relationshipId(data?.filterMunicipality)
|
|
if (!municipalityID) return true
|
|
|
|
const municipalityIDs = await getAccessibleMunicipalityIds(req, currentUser)
|
|
return municipalityIDs?.includes(municipalityID) ?? false
|
|
}
|
|
|
|
export const canReadCalendarFeed: Access = async ({ req }) => {
|
|
if (isPayloadAdmin(req.user)) return true
|
|
|
|
const currentUser = await getFreshCampaignUser(req)
|
|
if (isCampaignUnrestricted(currentUser)) return true
|
|
if (!currentUser || currentUser.role !== 'advisor') return false
|
|
|
|
return { createdBy: { equals: currentUser.id } }
|
|
}
|
|
|
|
export const canUpdateCalendarFeed: Access = async ({ req }) => {
|
|
if (isPayloadAdmin(req.user)) return true
|
|
|
|
const currentUser = await getFreshCampaignUser(req)
|
|
if (isCampaignUnrestricted(currentUser)) return true
|
|
if (!currentUser || currentUser.role !== 'advisor') return false
|
|
|
|
return { createdBy: { equals: currentUser.id } }
|
|
}
|
|
|
|
export const canDeleteCalendarFeed: Access = async ({ req }) => {
|
|
if (isPayloadAdmin(req.user)) return true
|
|
|
|
const currentUser = await getFreshCampaignUser(req)
|
|
if (isCampaignUnrestricted(currentUser)) return true
|
|
if (!currentUser || currentUser.role !== 'advisor') return false
|
|
|
|
return { createdBy: { equals: currentUser.id } }
|
|
}
|
|
|
|
export const canSetCalendarFeedSystemField: FieldAccess = ({ req }) => isPayloadAdmin(req.user)
|
|
|
|
/**
|
|
* Staff may mint a feed's secret on create; only Payload admin rotates it.
|
|
* The read side is kept `() => false` in the collection, so the credential is
|
|
* never re-read; `update` stays admin-only (revoke+recreate, never in place).
|
|
*/
|
|
export const canSetCalendarFeedSecret: FieldAccess = async ({ req }) => {
|
|
if (isPayloadAdmin(req.user)) return true
|
|
|
|
return isCampaignStaff(await getFreshCampaignUser(req))
|
|
}
|
|
|
|
/**
|
|
* Staff may mark a feed revoked (update only). `canUpdateCalendarFeed` already
|
|
* scopes advisors to their own feeds, so a staff member can only revoke a feed
|
|
* they created.
|
|
*/
|
|
export const canSetCalendarFeedRevocation: FieldAccess = async ({ req }) => {
|
|
if (isPayloadAdmin(req.user)) return true
|
|
|
|
return isCampaignStaff(await getFreshCampaignUser(req))
|
|
}
|